middlebury / midd-frontend

Frontend code for middlebury_theme
https://midd-frontend.now.sh
GNU General Public License v3.0
0 stars 0 forks source link

coursehub nav dropdowns broken on tablet/mobile #275

Closed zebapy closed 4 years ago

zebapy commented 4 years ago

Screenshot 2020-03-17 11 27 57

likely a minify issue affecting class specificity for the navsublist / nav-dropdownmenu class

this is caused by https://github.com/middlebury/drupal8/blob/master/web/themes/custom/coursehub_theme/css/menu.css

zebapy commented 4 years ago

@adamfranco this is caused by https://github.com/middlebury/drupal8/blob/master/web/themes/custom/coursehub_theme/css/menu.css

thoughts? Can we remove that css override? Or I guess I can bump up the width defined in this repo if it's needed.

adamfranco commented 4 years ago

Thanks, Zeb. Let me take a look at why I had added that...

adamfranco commented 4 years ago

I added a break-point to make the style override only apply on screen-sizes above 1024px. I also updated the selector to target just that last drop-down with the academic calender links that are a bit too wide otherwise. Let me know if you end up increasing the width and I can remove this override.