search

middleman / middleman-asciidoc

:beginner: AsciiDoc support for Middleman 4. (In Middleman 3, AsciiDoc support is provided by a core extension).
https://middlemanapp.com
Other
27 stars 12 forks source link

resolves #93 allow soft unsetting built-in attributes #96

Closed FiveYellowMice closed 3 years ago

mojavelinux commented 3 years ago

This looks really great. Thanks for including tests to verify the behavior.

The failures look unrelated. I'll look into what that's happening. Stay tuned.

mojavelinux commented 3 years ago

I fixed the broken tests. Can you rebase?

mojavelinux commented 3 years ago

For now, I had to disable the tests on JRuby due to dependency resolution problems. If you can upgrade the dependencies in a separate PR, perhaps we can get JRuby working again.

FiveYellowMice commented 3 years ago

Thanks! Rebase is done. All tests passed for me, but the CI doesn't seem to be triggering, will this be a problem?

mojavelinux commented 3 years ago

We'll need to switch away from Travis CI. But that's a separate issue. I'll proceed with the merge, then do that.

Thanks!