search

middleman / middleman-blog

Blog Engine Extension for Middleman
https://middlemanapp.com
MIT License
325 stars 179 forks source link

page_articles.each doesn't pick the I18n language from the file name anymore #344

Open andreamoro opened 7 years ago

andreamoro commented 7 years ago

Expected behaviour

The same that was happening with v. 4.0.1 were everything was working fine. Two separate blog instances in the config,rb were pulling out the list of content with the page_articles.each do

Actual behaviour

A page_articles.each do returns content only for the first of the two blogs only.

Steps to reproduce the problem

Config.rb file as

activate :i18n, :mount_at_root => false, :templates_dir => "content", :locales => [:en, :it]

activate :blog do |blogen| blogen.name = "blogit"; blogen.prefix = 'en/blog' ... end

activate :blog do |blogit| blogit.name = "blogit"; blogit.prefix = 'it/blog' ... end

Create two files, one with .en and one with the .it extension within

Use the page_articles method to pull out the list of content.

Additional information

iwarner commented 7 years ago

I dont believe much regarding this was updated in the latest version - please continue to use the older one in the meantime and I will investigate.

andreamoro commented 7 years ago

Hi @iwarner not sure what to say. By the time I forced the 4.0.1 version everything gone back to work as normal. Does this version include the template stuff and the i18n we discussed last time and for which you setup that repo?

iwarner commented 7 years ago

You can see what changed in the commits:

https://github.com/middleman/middleman-blog/commit/a8dd9fe352b4d7962e0b0e48c5ff4556c73d246e

My understanding is that page articles always pulled the default blog, and would not pull from two blogs.

andreamoro commented 7 years ago

Hi @iwarner this is the case until you don't specify the blog name in the frontmatter. By the time you have your file containing something like blog: blogname the right instance is pulled out and content rendered (so long you are on 4.0.1).

On 4.0.2 this suddenly got broken, but skimming the code I don't see anything strange that could have impacted this behaviour.

markets commented 4 months ago

ℹ️ This issue is stale because it has been open for more than 90 days with no activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.