search

middleman / middleman-blog

Blog Engine Extension for Middleman
https://middlemanapp.com
MIT License
325 stars 179 forks source link

Unexpected escape to unicode(also multibyte language) charcter for tag output. #345

Closed hsbt closed 7 years ago

hsbt commented 7 years ago

Hello, I encountered unexpected escape to unicode character on tag function. I created cucumber feature of my issue. It happens at v4.0.2. v4.0.1 is not affected.

Is it intentional behavior?

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 92.8% when pulling 2e06bfe811f5470f6f9e43ae49a6293a40e840cd on hsbt:i18n-tags into e495bbebfac3d10b3093b9b4e6a9fb30f4e735d3 on middleman:master.

iwarner commented 7 years ago

@hsbt Hiya

Please check the last commit I did - I did change the slugifier somewhat for tags, current DoubleChars in the tests did not seem effected

If you can play around with that slugfier and compare new and old and PR for this then that would be great.

I will check out also

hsbt commented 7 years ago

Please check the last commit I did

Do you point this commit?: https://github.com/middleman/middleman-blog/commit/a8dd9fe352b4d7962e0b0e48c5ff4556c73d246e

iwarner commented 7 years ago

I have fixed this, reverted back and made some tweaks on the safe parametize and included your tests - thank you.

Please revert to 4.0.1 for now and I will be releasing a 5.0.0 soon - but this will have some breaking changes in. I am trying to fix the locale settings through blog which is a beast.

hsbt commented 7 years ago

Make sense. Thanks for your direction. I'm waiting for next release.