search

middleman / middleman-livereload

LiveReload support for Middleman
http://middlemanapp.com
MIT License
117 stars 37 forks source link

Update to middleman 4.1.1 and fix :ignore option #89

Closed adam-h closed 8 years ago

adam-h commented 8 years ago

This should also work on middleman 4.0, but I have not tested that.

Documentation was unclear as to how the :ignore option should work, but it didn't seem to be working :( So this makes it accept regular expressions.

tdreyno commented 8 years ago

This gem should support both versions 3 and 4, so we don't want to make backwards incompatible changes.

jessepollak commented 8 years ago

+1 for this change

tdreyno commented 8 years ago

Me too, the actual fix is unrelated to dropping 3.x support.

jessepollak commented 8 years ago

I can put in the work to make this work, if I understand the compatibility issue. Would dropping everything except for the ignore specific changes at 46 and 71 (and making them support both forms) be the right way to proceed?

tdreyno commented 8 years ago

Seems like the only necessary change is making the two guard clauses (the next bit) also take into account the ignore.any? { |i| file.to_s.match(i) } ... But, it should continue to also use the Middleman-wide ignore, which is that respond_to stuff because that API changed between v3/v4.

tdreyno commented 8 years ago

So, ignore it if it fails either the MM list or the ignore list

pdlug commented 8 years ago

Any reason this hasn't been merged in yet? It would be really helpful to have working ignore functionality w/ livereload in MM 4.x

jessepollak commented 8 years ago

@pdlug this was fixed by #91 and I think this PR can be closed without merging.