search

middleman / middleman-minify-html

A HTML whitespace minifier for Middleman
https://middlemanapp.com/
MIT License
77 stars 13 forks source link

Minify breaks .htaccess #6

Closed chrkau closed 11 years ago

chrkau commented 11 years ago

The extension tries to compress .htaccess files which break in the process.

bhollis commented 11 years ago

The problem is that Middleman serves .htaccess as text/html, which isn't correct. I'll look at fixing that.

bhollis commented 11 years ago

Closing in favor of the linked pull request. Thanks for letting us know!

mcoms commented 11 years ago

Still encountering this issue with middleman 3.0.11, even though I think the pull request made it in :(

chrkau commented 11 years ago

Confirmed. Still happens in 3.0.11

bhollis commented 11 years ago

My change was made after 3.0.11 was released, you'll have to wait for the next release.

hous commented 11 years ago

Confirmed that this issue is still present in 3.0.12.

stepin commented 11 years ago

Same bug with 3.0.12

stepin commented 11 years ago

Looks like fix in the master branch, not 3.0-stable. So, for now it will be released in 3.1 only.

LeonB commented 11 years ago

Is this something that could be backported to the 3.0-stable branch?

bhollis commented 11 years ago

Right you are. I've backported it to 3.0-stable, and it'll be released in 3.0.13 if that happens, or 3.1.