search

middleman / middleman-syntax

Code syntax highlighting plugin via Rouge for Middleman
https://middlemanapp.com
MIT License
179 stars 57 forks source link

Rejig Gemfiles for consistency across Middleman repo's #22

Closed karlfreeman closed 11 years ago

bhollis commented 11 years ago

Rouge will never work for 1.8.7 or jruby-18-mode, and thus neither will middleman-syntax. Running tests for it is just a waste of Travis CI's resources.

I don't personally see the point in having :test and :development sections in the Gemfile - what does it get you?

karlfreeman commented 11 years ago

Rouge - Ok, Fair point. I'll ditch 1.8.7 and jruby-18-mode testing from travis.

Bundler Groups - I've always seen it as best practice. It appears to stem from splitting gem dependancies further then just :test and :development. For me personally it just reads a little better. Whats your thoughts?

bhollis commented 11 years ago

But we don't use the groups at all - nobody just installs the development gems while developing Middleman, because you also need the test tools. And we don't just require some of them either. You always need all of them.

karlfreeman commented 11 years ago

So it looks the build is back to working again, however testing middleman-syntax against middleman ~> 3.0.0 has cropped up a bug.

bhollis commented 11 years ago

OK. If you'll fix these last issues, I'll merge this, and then dig into what the 3.0 problem is.

karlfreeman commented 11 years ago

Good catch! A tad too much consistency!