search

middleman / middleman-syntax

Code syntax highlighting plugin via Rouge for Middleman
https://middlemanapp.com
MIT License
179 stars 57 forks source link

Ruby 2.0 incompatibility #44

Closed nayefc closed 10 years ago

nayefc commented 10 years ago

Hello,

For some reason, my syntax styling is broken. I think this happened once I upgraded to Ruby 2.0.

Here is a sample: http://nayefcopty.com/blog/styling-changes/

My config: 

activate :syntax, line_numbers: true
Arcovion commented 10 years ago

We require the rouge gem at ~> 1.0, so updating your gems probably brought in a newer version of that gem... check the changelog here. I suggest you reopen this over there, middleman-syntax is mainly just a wrapper for rouge.

Arcovion commented 10 years ago

Looking at the way rouge handles line numbers I think it can be improved MASSIVELY, the current system even having been changed is not very good. I will try to put together a PR to rewrite it soon! Maybe in time for my other PR to be merged, which I think is being ignored as Slim is taking priority - we can't update middleman-syntax until those problems are addressed.

nayefc commented 10 years ago

It was rouge being at 1.3. Downgrading to 1.0 fixes it. Thanks!

Arcovion commented 10 years ago

@nayefc Keep in mind this will change in future, for reasons mentioned in the changelog. (Wrapping

in 
 isn't valid).
            
        
    
    

            


    

        
    
            
  • ©  Githubissues.
    • 
            
  • Githubissues is a development platform for aggregating issues.
    •