search

middleman / middleman-syntax

Code syntax highlighting plugin via Rouge for Middleman
https://middlemanapp.com
MIT License
179 stars 57 forks source link

Allow using Haml 6.0 and drop 5.x and earlier #81

Closed tnir closed 7 months ago

tnir commented 1 year ago

Closes #80

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

k0kubun commented 1 year ago

You might be interested in this discussion: https://github.com/haml/haml/issues/1089

bostonaholic commented 1 year ago

Any updates on when this can get merged? middleman-syntax 3.3.0 still does not support haml 6.x.x.

markets commented 7 months ago

@tdreyno could you please merge and release this one 🙏🏼? Since MM v4.5.0 (https://github.com/middleman/middleman/blob/main/CHANGELOG.md#450) Haml 6 is already supported by MM, but incompatible with this plugin.

In the meantime, I'm using @tnir's fork:

gem "middleman-syntax", github: "tnir/middleman-syntax", branch: "haml-6.x"

Another solution is to freeze the Haml gem:

gem "haml", "< 6"
bostonaholic commented 7 months ago

@tnir Could you remove the Draft status of this PR and make it ready for review so it can get merged and released?

tdreyno commented 7 months ago

Can we do this without dropping support for Haml 5? I'd prefer not to have a breaking change.

markets commented 7 months ago

That makes sense! @tnir could you please update your patch 🙏🏼?

markets commented 7 months ago

@tnir @tdreyno just in case, proposed a new PR here 👉🏼 https://github.com/middleman/middleman-syntax/pull/82