search

middleman / middleman-syntax

Code syntax highlighting plugin via Rouge for Middleman
https://middlemanapp.com
MIT License
179 stars 57 forks source link

Fix Haml 6 support #84

Closed markets closed 7 months ago

markets commented 7 months ago

It seems that changes from #82 are incomplete to fully support Haml 6, so this branch is intended to fix that.

markets commented 7 months ago

Hello @amatsuda 👋🏼

Sorry for the ping 🙏🏼, but since you contributed recently to MM and you are a Haml maintainer, could you please help us with that? I'm trying to give this plugin Haml 6 support.

This is all the related code: https://github.com/middleman/middleman-syntax/blob/master/lib/middleman-syntax/haml_monkey_patch.rb.

markets commented 7 months ago

Yay! Haml 5 and 6 working 🎉

@tdreyno This is ready for review 👀 and merge @amatsuda I think I finally got it working, see this commit 140fd7bac0eace3313bdf9a5f222c290c8e7bf79

amatsuda commented 7 months ago

@markets Sorry for responding late, but yes, this patch looks good!