search

middleman / middleman

Hand-crafted frontend development
https://middlemanapp.com
MIT License
7.04k stars 746 forks source link

Padrino-helpers 0.12.4 changes content-type handling which affects Middleman #1546

Closed komor72 closed 9 years ago

komor72 commented 9 years ago

I just upgraded a project from Middleman 3.3.12 to 3.4.0 (directly from Github repo) and at the same time Padrino-helpers were upped from 0.12.3 to 0.12.5. After usual middleman build I diffed the old and new output and noticed missing content-type declarations in build output.

Like this, before upgrade (MM 3.3.12, Padrino-helpers 0.12.3):

<link href="css/myproject.css" rel="stylesheet" type="text/css" />

After upgrade (MM 3.4.0 from v3-stable, Padrino-helpers 0.12.5):

<link href="css/myproject.css" rel="stylesheet" />

Same for Javascript helper. After looking into Padrino matters I spotted this in their changelog: FIX #1781 Removes the default_filters method setting incorrect content-type. The corresponding PR, and corresponding commit. If I correctly identified the source of change, then maybe it’s easy to fix this in Middleman. :)

tdreyno commented 9 years ago

I actually removed this manually in my commit. It's no longer necessary in HTML5. Any reason to add it back?

komor72 commented 9 years ago

You are right, I’ve checked the specs. Well, it’s not a big deal, most of us use HTML5 specs anyway, these days. Although, as a sidenote, I’m not a big fan of early and eager feature removal if it doesn’t hurt to still support them. Now, formally, all non-html5 Middleman templates and projects are obsolete. Not a problem for me.