search

middlewarehq / middleware

✨ Open-source DORA metrics platform for engineering teams ✨
https://middlewarehq.com
Apache License 2.0
1.06k stars 70 forks source link

The scripts should exit if directories are not found #308

Closed amoghjalan closed 4 months ago

amoghjalan commented 4 months ago

Ref: https://github.com/koalaman/shellcheck/wiki/SC2164

Linked Issue(s)

Acceptance Criteria fulfillment

Proposed changes (including videos or screenshots)

Further comments

adnanhashmi09 commented 4 months ago

Please add an exit code of 127 as well. Otherwise it will exit with the default code of 0.

amoghjalan commented 4 months ago

Please add an exit code of 127 as well. Otherwise it will exit with the default code of 0.

127 is used for command not found, rather over here the command is correct the directory may not be available