search

middlewarehq / middleware

✨ Open-source dev productivity platform for engineering teams ✨
https://middlewarehq.com
Apache License 2.0
388 stars 32 forks source link

Wrong Deployments number shown #407

Open gabrielenosso opened 1 month ago

gabrielenosso commented 1 month ago

Description:

Number of deployments shown is completely wrong. Also deployments shown are not considering the branch selected.

Steps to reproduce:

Selected default production branch as "master" image

Deployments shown are considering all branches (it should consider only the "master" branch) image So numbers and data here are wrong (first problem).

Second problem: from the previous screenshot you can see that there are 2 deployments to the master branch. But the dashboard shows only 1 per week (when you can see that I selected only 3 days...). Also the tooltip says "2 deployments over 0 weeks 6 days"... number of deployments here is correct, but time is wrong (should be 3 days) image

Expected behavior:

numbers shown are correct

Server Setup Information:

just followed the instructions on the readme to start the app

shivam-bit commented 1 month ago

Hi @gabrielenosso Thanks for reporting this. I am looking into it and will keep you posted on this issue.

shivam-bit commented 1 month ago

Hi @gabrielenosso The first issue has been resolved; deployments will now only show insights specific to the selected branch mode. You can pull the latest changes and try it out.

PS- we are still looking into the second issue.

amoghjalan commented 4 weeks ago

Hi @gabrielenosso Thank you for bringing this to our attention. We've identified that this issue occurs when the selected date range is less than 7 days. After careful consideration, we believe that metrics for such a short duration don't add much value. Therefore, we are considering setting the minimum date range to 7 days.

We'd love to hear your thoughts on this approach and any feedback you might have.

gabrielenosso commented 3 weeks ago

Makes sense. 1 week is fine as minimum. Point is all UI should not permit a selection of less than 7 days then (and it should be clear :) )