issues
search
middlewarehq
/
middleware
✨ Open-source DORA metrics platform for engineering teams ✨
https://middlewarehq.com
Apache License 2.0
1.05k
stars
64
forks
source link
feat:Update prod and dev version checking logic
#418
Closed
samad-yar-khan
closed
3 months ago
samad-yar-khan
commented
3 months ago
Linked Issue(s)
Acceptance Criteria fulfillment
[x] Updated docker files to accept
MERGE_COMMIT_SHA
and
BUILD_DATE
[x] Update build file to populate docker args
[x] Update dev.sh to read git commit and write vars into env file
[x] Update versions API logic
Proposed changes (including videos or screenshots)
Build file will populate env vars inside the docker image. Env vars will have merge commit and docker image build date for prod image
dev.sh will write
MERGE_COMMIT_SHA
and
BUILD_DATE
and .env is populated to docker container env inside Dockerfile.dev
for prod env:
MERGE_COMMIT_SHA = populated via gh actions and is merge commit
BUILD_DATE = Docker image build date
We check if image build date is before or after the docker remote build date
for dev env
MERGE_COMMIT_SHA = populated via dev.sh and is the commit of main branch
BUILD_DATE = timestamp of commit
We check if image build date is before or after the commit timestamp of latest commit on remote
Further comments
Linked Issue(s)
Acceptance Criteria fulfillment
MERGE_COMMIT_SHA
andBUILD_DATE
Proposed changes (including videos or screenshots)
MERGE_COMMIT_SHA
andBUILD_DATE
and .env is populated to docker container env inside Dockerfile.devFurther comments