middlewarehq / middleware

✨ Open-source dev productivity platform for engineering teams ✨

https://middlewarehq.com

Apache License 2.0

388 stars 31 forks source link

Fix: sort reviewers by Name #429

Closed VipinDevelops closed 2 weeks ago

VipinDevelops commented 3 weeks ago

Linked Issue(s)

398

Acceptance Criteria fulfillment

[x] When sorting Reviewers, the number of reviewers is the primary sort, and alphabetically after that

Proposed changes (including videos or screenshots)

Before

After

CLAassistant commented 3 weeks ago

All committers have signed the CLA.

VipinDevelops commented 3 weeks ago

Hey, @e-for-eshaan Can you please take a look at this PR, To solve the error, I used the spread operator ([...]) to create a shallow copy of the pr.reviewers array before sorting it, preventing the mutation of the original array.

VipinDevelops commented 2 weeks ago

LGTM! Congrats on getting this merged, sire!

Thanks for merging this :) .