Added Search Suggestions for repo-search

middlewarehq / middleware

✨ Open-source DORA metrics platform for engineering teams ✨

https://middlewarehq.com

Apache License 2.0

1.05k stars 64 forks source link

Added Search Suggestions for repo-search #448

Closed KartikChawla09 closed 3 months ago

KartikChawla09 commented 3 months ago

Linked Issue(s)

Closes #445 by adding animated search suggestions.

Acceptance Criteria fulfillment

[x] try not to add any additional packages
[x] theme must be kept similiar to the pre-existing UI
[x] write optimized and efficient code

Proposed changes (including videos or screenshots)

https://github.com/middlewarehq/middleware/assets/97456320/615286d1-365a-4007-b9c7-87a3fe2d7619

KartikChawla09 commented 3 months ago

Thank you so much for your contribution! 🚀

There's a couple of things that need your attention. Not every comment needs a change to be made, some might just need some clarification. :)

Hey! Thank you very much for your review! I took the AnimatedInputWrapper component from the codesandbox link provided in the issue (https://github.com/middlewarehq/middleware/issues/445#issuecomment-2184969405) because I assumed it had to be used as is. Apologies for the misinterpretation. I will make the necessary changes or go back to my initial approach of using the Slide MUI Component if required.

KartikChawla09 commented 3 months ago

@jayantbh Can you please review the updated code once ?

jayantbh commented 3 months ago

Hey again @KartikChawla09, sorry about the delay on this. I'm away from work this week so I didn't look at this PR again. But I will in a day or two. 👌

jayantbh commented 3 months ago

@KartikChawla09 this would be the command to run: yarn eslint --fix ./source/**/*.*

KartikChawla09 commented 3 months ago

@KartikChawla09 this would be the command to run: yarn eslint --fix ./source/**/*.*

I ran the command and it executed without any errors in both the directories.

jayantbh commented 3 months ago

Right, I guess it doesn't cover the CSS file at the moment. We'll let this one pass, we'll deal with the linting issues shortly (but not block this PR over it).