Open sidtohan opened 3 days ago
Great suggestion, @sidtohan! Thanks for your PR. We'll look into this.
Btw, did you run npm install
by any chance?
Because cli/package-lock.json
should not be a new file. You'll see there should be a yarn.lock
indicating that it should use yarn
as the package manager.
As a result, your PR blew to 7.6k lines. :)
Linked Issue(s)
fixes #338
Acceptance Criteria fulfillment
Proposed changes (including videos or screenshots)
PREREQ_CHECK
, which denotes that the app is currently checking the prerequisites. Also, the initial state of the app is nowPREREQ_CHECK
instead ofINIT
.cli/source/constants.ts
calledPreCheckStates
consisting of three values:RUNNING, SUCCESS
andFAILED
.Further comments
There are currently a lot of major changes regarding the dependency arrays for the
useEffect
and theuseCallback
hooks. I have currently implemented them as per my opinion, but I would appreciate some guidance on how we can make it look more cleaner and better.There is currently a lot of work to be done on the UI as well, but I would first like to get some feedback on the type of approach I've taken. Thanks.