middlewarehq / middleware

✨ Open-source dev productivity platform for engineering teams ✨
https://middlewarehq.com
Apache License 2.0
388 stars 32 forks source link

fix: added a prerequisite check to ensure certain conditions are fulfilled before running docker compose build and watch #451

Open sidtohan opened 3 days ago

sidtohan commented 3 days ago

Linked Issue(s)

fixes #338

Acceptance Criteria fulfillment

Proposed changes (including videos or screenshots)

Further comments

There are currently a lot of major changes regarding the dependency arrays for the useEffect and the useCallback hooks. I have currently implemented them as per my opinion, but I would appreciate some guidance on how we can make it look more cleaner and better.

There is currently a lot of work to be done on the UI as well, but I would first like to get some feedback on the type of approach I've taken. Thanks.

jayantbh commented 6 hours ago

Great suggestion, @sidtohan! Thanks for your PR. We'll look into this.

jayantbh commented 6 hours ago

Btw, did you run npm install by any chance? Because cli/package-lock.json should not be a new file. You'll see there should be a yarn.lock indicating that it should use yarn as the package manager.

As a result, your PR blew to 7.6k lines. :)