Add a `Star this repo on Github` button

middlewarehq / middleware

✨ Open-source DORA metrics platform for engineering teams ✨

https://middlewarehq.com

Apache License 2.0

1.01k stars 58 forks source link

Add a `Star this repo on Github` button #454

Open e-for-eshaan opened 2 months ago

e-for-eshaan commented 2 months ago

Why do we need this ?

There is no CTA on our app for the users to nudge them to star our repo on GitHub. So creating a button that helps this is needed.

Further Comments / References

something like this:

sidtohan commented 1 month ago

So for this, should we have the button directly star the repository (using the github api) or should we redirect the user to the repository page (using something like this) ?

jayantbh commented 1 month ago

@sidtohan the latter. Basically a simple CTA in the sidebar (adhering to the theme of the app), at the bottom of it should be sufficient.

jayantbh commented 1 month ago

Are you interested in taking this up?

sidtohan commented 1 month ago

Are you interested in taking this up?

Yes I would be interested in working on this :)

sidtohan commented 1 month ago

Hey so is there any update on this issue? If it is still in consideration I would like to work on this.

jayantbh commented 1 month ago

Hey apologies I missed the notification. Sure, feel free to take this up, @sidtohan!

jayantbh commented 1 month ago

Because this will be a visual change, please share your approach/idea for changes before implementing anything.

Ankur1493 commented 1 month ago

but we already have this in navbar

sidtohan commented 1 month ago

but we already have this in navbar

That's a good catch. Do we need this or something different? @jayantbh

jayantbh commented 1 month ago

Something different is acceptable, @Ankur1493 and @sidtohan

The screenshot shared belongs to the landing page. This issue talks about adding a CTA to the docker app.

e-for-eshaan commented 1 week ago

@sidtohan been a while, how's are things looking for this?

If you are unable to pick this up, let us know!

sidtohan commented 1 week ago

@sidtohan been a while, how's are things looking for this?

If you are unable to pick this up, let us know!

Hello,

I am facing an issue with the hardware itself of my laptop. It would not be possible to work on this particular issue, so I would request you to assign this to someone else.

samad-yar-khan commented 1 week ago

but we already have this in navbar

That is on our landing page. We also need a similar functionality within Middleware Opensource.

Kamlesh72 commented 1 week ago

Suggestions? 🤔

e-for-eshaan commented 1 week ago

Hey @Kamlesh72 , not the place i would want it to be. How about the top-right section of the page-headers? cc: @jayantbh

Kamlesh72 commented 1 week ago

It looks good, but it is very close to loading (can be ignored). If we go with this, should it be shown on every page or just DORA metrics?

Transparent Background 👇🏻

e-for-eshaan commented 1 week ago

Hey @Kamlesh72 , can you raise a PR, so we can start commenting there. Will be easier for me to pick stuff-up for referencing in my comments!

e-for-eshaan commented 1 week ago

Also, I am assigning this issue to you!

e-for-eshaan commented 5 days ago

@Kamlesh72 did you manage to raise a PR? You can start with proof-of-concept PR, and then work on it, building and polishing it w.r.t the reviewer-comments.

Kamlesh72 commented 5 days ago

@e-for-eshaan Not yet. I got some urgent work so was not able to do it, so sorry.

I will make the PR by tonight.