search

middlewares / php-session

PSR-15 middleware to create a php session using the request data
MIT License
14 stars 3 forks source link

Use arrays instead of string concatenation #11

Closed szepeviktor closed 2 years ago

szepeviktor commented 2 years ago

Conflict resolved 🍏

oscarotero commented 2 years ago

Thanks, but I don't see any advantage of this change. It makes the code more complicated and the need to do things like $cookieAttributes['Secure'] = null; to enable secure flag is confusing.

szepeviktor commented 2 years ago

I agree with you. String concatenation is on my blacklist.