search

middlewares / utils

Common utils used by PSR-15 middlewares
MIT License
51 stars 12 forks source link

New strategy for Sunrise library #12

Closed sunrise-php closed 5 years ago

sunrise-php commented 5 years ago

New strategy for my packages...

sunrise-php commented 5 years ago

My packages for PHP 7.2+. How to solve this problem?

oscarotero commented 5 years ago

There's the feature/psr-17 branch, created to use the factories provided by the different packages (diactoros, guzzle, etc) and likely will be released as a new major version, removing support for php 7.0 and, maybe, php 7.1. Note also that you don't have to create a factory class, just add your factory classes to the strategies array: https://github.com/middlewares/utils/blob/feature/psr-17/src/Factory.php#L25

fenric commented 5 years ago

@oscarotero class names is valid:

Sunrise\Http\ServerRequest\ServerRequestFactory
Sunrise\Http\Message\ResponseFactory
Sunrise\Stream\StreamFactory
Sunrise\Uri\UriFactory

tests is passed:

https://travis-ci.com/sunrise-php/http-server-request https://travis-ci.com/sunrise-php/http-message https://travis-ci.com/sunrise-php/stream https://travis-ci.com/sunrise-php/uri

oscarotero commented 5 years ago

You've created this pull request from master branch. Please, use the feature/psr-17 as the base branch to add your library.

sunrise-php commented 5 years ago

You've created this pull request from master branch. Please, use the feature/psr-17 as the base branch to add your library.

Something went wrong :) Please, my new normal request: https://github.com/middlewares/utils/pull/13