search

middlewares / utils

Common utils used by PSR-15 middlewares
MIT License
51 stars 12 forks source link

use official PSR-15 packages #8

Closed ecolinet closed 6 years ago

ecolinet commented 6 years ago

Use official PSR-15 package instead of the interop ones

oscarotero commented 6 years ago

Thank you 👍

ecolinet commented 6 years ago

You're welcome. I wonder why you have the composer.lock file in the .gitignore file (?)

oscarotero commented 6 years ago

Because this package is installed as a dependency. IMO, lock files should exists in the root project, not in its dependencies.

ecolinet commented 6 years ago

You're right, but it could be useful for travis for example. And in any case the project doesn't inherit from it. Your choice !

2018-01-23 20:49 GMT+01:00 Oscar Otero notifications@github.com:

Because this package is installed as a dependency. IMO, lock files should exists in the root project, not in its dependencies.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/middlewares/utils/pull/8#issuecomment-359908675, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD_4pVryexH28bx9oS9RInX9xRKlbLRks5tNjfJgaJpZM4Rp77k .