search

midgardproject / phpcr-midgard2

Midgard2 implementation of PHP Content Repository (PHPCR)
http://midgard-project.org/phpcr/
46 stars 4 forks source link

Remove static from RepositoryFactory #155

Closed treffynnon closed 11 years ago

treffynnon commented 11 years ago

Since upstream commit https://github.com/phpcr/phpcr/commit/237222165f85672ddae5d2f69105f5b1e431a7ee the interface no longer allows static methods.

piotras commented 11 years ago

What is this pull request? I can't see any related commit(s).

treffynnon commented 11 years ago

Argh you're right. I did the slight change via the github web editing interface. It looked like it had worked, but obviously it hasn't - I thought it was acting weird on this pull request. I will make the change again. Sorry about that.

piotras commented 11 years ago

No problem :) I applied changes related to type conversions and static declarations BTW.

treffynnon commented 11 years ago

Ah ok cool. This pull request is redundant then anyway. Closing... :)