Switching implementation from mod.rs to file names based on module name

midi2-dev / bl-midi2-rs

Ergonomic, versatile, strong types wrapping MIDI 2.0 message data.

https://crates.io/crates/midi2

Apache License 2.0

22 stars 4 forks source link

Switching implementation from mod.rs to file names based on module name #18

Closed Hasnabruzzn closed 4 months ago

Hasnabruzzn commented 4 months ago

as per https://github.com/BenLeadbetter/midi2/issues/17 Affected modules

channel_voice1
channel_voice2
ci (also adding path to README.md in ci.rs)
detail
flex_date
sysex7 (also adding path to README.md in sysex7.rs)
sysex8
system_common (also adding path to README.md in system_common.rs)
ump_stream
utility

Hasnabruzzn commented 4 months ago

Please note: This is my very first contribution to any project and I had first to learn how to do this with GitHub (hope everything is ok)

BenLeadbetter commented 4 months ago

Thanks for the PR!

New changes should go against develop rather than main. (I should probably make develop the default branch and update the contribution docs.)

I've changed the target branch but this has unfortunately created a couple of conflicts. Let me know if you have any queries regarding their resolution.

Hasnabruzzn commented 4 months ago

Sorry for creating a mess!

BenLeadbetter commented 4 months ago

Not at all! Like I said - the defaults are confusing. I'm still sussing out this open contribution thing myself- you're the first 😅💙

BenLeadbetter commented 4 months ago

Would you like a hand rebasing this branch? I'm planning another release soon and it would be good to include this patch, if possible.

Hasnabruzzn commented 4 months ago

Should I do the fork based on the develop branch? For that I have to delete my current fork (GitHub tries to scare me: ) ... or is it ok to stay based on main and do the pull request into the develop branch?

BenLeadbetter commented 4 months ago

Hmm. I would have though that you could "rebase" your branch on my upstream develop branch and these errors would go away. Shouldn't need to delete your fork !