midi2-dev / bl-midi2-rs

Ergonomic, versatile, strong types wrapping MIDI 2.0 message data.
https://crates.io/crates/midi2
Apache License 2.0
18 stars 2 forks source link

Implement some feedback points #23

Closed BenLeadbetter closed 3 weeks ago

BenLeadbetter commented 1 month ago

Used Fixed Point Types For Pitch Data

For the Pitch7_9 note attribute and the Pitch7_25 controller data we use fixed point numerical types via the fixed 3rd party crate.

Rename *note properties to *note_number

This naming better captures the intended semantics of this property in midi2: this data isn't requesting an explicit pitch (like the pitch data mentioned above) it is more of a semantic "note" - the interpretation of the "pitch" is up to the receiver. note_number better captures these semantics.