midniteio / multi-cuke

Parallel cucumber-js testing via Node's child_process.spawn api
13 stars 4 forks source link

Multicuke returns 0 for invalid feature files, but cucumber-js returns 1 #24

Closed guykisel closed 8 years ago

guykisel commented 8 years ago

If the feature files we try to run are all invalid due to bad syntax, multi-cuke returns a null exit code, but for the same files, cucumber-js returns 1. It might be better if multi-cuke was consistent with cucumber-js.

(also I realize this is intentional behavior, but I still wonder if it might be better to be consistent with the tool we're wrapping - example use case is that someone updates all of the feature files but accidentally leaves in merge conflict garbage, rendering all feature files invalid - the tests would all just pass and you might never notice unless you glanced at console logs)