midokura / helm-charts-community

A collection of Helm Charts for open-source programs
https://midokura.github.io/helm-charts-community/
Apache License 2.0
12 stars 12 forks source link

[nginx-static]: Fix nginx-config mount issue #64

Closed duhow closed 1 year ago

Sturgelose commented 1 year ago

Thought: why not extending this helm chart? https://artifacthub.io/packages/helm/bitnami/nginx

Even there are configs to handle what it trying to be handled in this chart (here)

I feel we are just rewriting this one but.... with git and disk support, which:

I don't want to suggest recreating the chart from scratch, but, I feel we are maintaining this (of course with low cost), when we could use the community :sweat_smile:

Anyways, approving as for the time being this is useful.

duhow commented 1 year ago

Valid concern... This chart was written based on legacy workflows where we would create unique Helm Charts to achieve the same result. Unsustainable. Crazy idea: let's make a single generic one, and so this Chart was born. We can check in the future what to do, but this is yet another open source alternative to use. 🙂