Closed rossella closed 10 years ago
Ping @ryu25ishi
@rossella I still see Alex's changes getting re-applied with this commit (e18a21f). Could you rebase again to make sure that only your change are applied?
@ryu25ish my first commit reverted alex's changes. That's why I created a commit to reapply them. Even if I rebase this won't solve the issue, because the first commit applied on top will revert alex's commit. I can squash my commits into one. is that what you are suggesting?
@rossella Is this pull req still active?
@davecahill yes it should, this is the code that passed the RHOS certification. I will rebase since it's not mergeable.
Thanks @tomoe it should be ok now!