search

midonet / tssrp6a

This library is a dependency free TypeScript implementation of Secure Remote Password SRP6a.
MIT License
36 stars 8 forks source link

Remove CryptoJS and Custom Hash Function #67

Closed jbis9051 closed 3 years ago

jbis9051 commented 3 years ago

Fixes #53 and Fixes #47

jbis9051 commented 3 years ago

This will take a while before things compile and pass tests. I will probably need some help from @bgrosse-midokura and/or @bufistov specifically with things like this:

https://github.com/midonet/tssrp6a/blob/c07f0b7316f9c31bf8e355ed5a77437add2469d8/src/utils.ts#L161-L165

bufistov commented 3 years ago

I have very limited bandwidth last and next week and next month, sorry :(

bgrosse-midokura commented 3 years ago

I'm not that good with the bitwise operations :sweat_smile:

jbis9051 commented 3 years ago

Turns out we don't need those bitwise functions \o/

jbis9051 commented 3 years ago

Tests are passing locally. I've commented out some tests (see comments). I will work on compatibility with older node versions and browser.

jbis9051 commented 3 years ago

Should be compatible with browsers and most versions of Node. Tested on Node 16 and Node 14. Someone should probably test browser.

jbis9051 commented 3 years ago

I think you should squash into one or two commits, and then we can merge.

I think you should be able to do it when you merge.

bgrosse-midokura commented 3 years ago

actually not bad (the gh UI)