midoshouse / ootr-multiworld

An alternative implementation of multiworld for the Ocarina of Time randomizer
https://midos.house/mw
MIT License
9 stars 0 forks source link

BizHawk crashes when kicked #10

Closed fenhl closed 1 year ago

fenhl commented 1 year ago

The kick button is intended to be used when a client has already disconnected and the server just hasn't noticed yet, so this is low priority, but if you kick a BizHawk client that's still connected, it will crash that player's BizHawk (not just the tool). This is because it tries to get the effect type of the Goodbye message, which causes a Rust panic. A good way to fix this would be to add proper handling of Goodbye messages to reset the connection state like the Project64 client does.