midouest / vscode-playdate-debug

Unofficial Playdate debug extension for Visual Studio Code on macOS, Windows and Ubuntu
https://marketplace.visualstudio.com/items?itemName=midouest.playdate-debug
MIT License
38 stars 4 forks source link

Breakpoints no longer work in VSCode 1.73.x #7

Closed Minalien closed 1 year ago

Minalien commented 1 year ago

Breakpoints (both regular breakpoints and break-on-exceptions) fail to work in Visual Studio Code 1.73.0 and 1.73.1

Not sure if this is the cause of the break, but there do appear to be changes to the debug adapter protocol in 1.73? Not sure if this is something that needs adjustment in this extension, or something needing updating in the simulator itself. https://code.visualstudio.com/updates/v1_73#_debug-adapter-protocol

For now, workaround is to roll back VSCode to 1.72 (September 2022) or earlier.

midouest commented 1 year ago

Thanks for reporting this! I am looking into it.

FWIW It looks like breakpoints do still work in 1.73.x, but only if you set them after the debug adapter session has been launched. It looks like VSCode is not sending the initial breakpoints to the Playdate Simulator for some reason.

midouest commented 1 year ago

Fixed by a6e1eaebc3bcd8906ef4c7268950d8b92b1b5abf

Minalien commented 1 year ago

Confirmed working for me in 1.73.1, thanks so much! 💜