search

midspace / Space-Engineers-Admin-script-mod

Modding script for Space Engineers with dozens of Admin commands for creating game scenarios or supporting servers.
43 stars 13 forks source link

New bug/conflict issue with SE #142

Closed EngineerBean closed 8 years ago

EngineerBean commented 8 years ago

2016-01-08 18:12:05.943 - Thread: 1 -> Exception occured: System.NullReferenceException: Object reference not set to an instance of an object. at midspace.adminscripts.Protection.GameLogicComponents.ProtectedCubePlacer.UpdateBeforeSimulation() at Sandbox.Game.Entities.MyEntities.UpdateBeforeSimulation() at Sandbox.Game.World.MySector.UpdateBeforeSimulation() at Sandbox.Game.World.MySession.UpdateComponents() at Sandbox.Game.World.MySession.Update(MyTimeSpan updateTime) at Sandbox.MySandboxGame.Update() at Sandbox.Engine.Platform.Game.UpdateInternal() at Sandbox.Engine.Platform.FixedLoop.<>cDisplayClass2.b1() at Sandbox.Engine.Platform.GenericLoop.Run(VoidAction tickCallback) at Sandbox.Engine.Platform.Game.RunLoop() at Sandbox.MySandboxGame.Run(Boolean customRenderLoop, Action disposeSplashScreen) at SpaceEngineers.MyProgram.RunInternal(String[] args) at SpaceEngineers.MyProgram.Main(String[] args)

midspace commented 8 years ago

This seems to agree with this issue posted here: http://forum.keenswh.com/threads/01-116-ds-client-crash-when-selecting-any-block.7377855/

Only details, is that it is occurring on a dedicated server. Do we have anything else to go on?

midspace commented 8 years ago

Here is a copy of the log in the thread. I haven't been able to reproduce the issue as yet. I have a dedicated server running with Protected area, and I have added all mods specified in the log, in the order specified in the log. I have even removed my Admin status, and it still isn't giving me any exception.

http://pastebin.com/P4pQbwnB

midspace commented 8 years ago

At the moment, I'm guessing the player might be trying to place a block before permissions and protection zones has downloaded? SpaceMarine?

Spcemarine commented 8 years ago

Yes, that'd be possible but still it is extremely weird that the permissions are not downloaded yet after about 30 seconds.

Spcemarine commented 8 years ago

Lets leave this open until we have evidence that the bug is fixed.

midspace commented 8 years ago

I'm wondering if we should have a null check in that first if? ProtectionHandler.Config != null

Spcemarine commented 8 years ago

!ChatCommandLogic.Instance.AllowBuilding in line 45 is only set to true after the client received the config from the server. If the config is still null we'll have to find out why. I think this approach allows us to track down the bug properly.

EngineerBean commented 8 years ago

Please forgive me for not including more information. This exception occured when selecting a block off toolbar on a dedicated server.

midspace commented 8 years ago

Has this issue been resolved? I have heard no further replies that it is still a problem.

midspace commented 8 years ago

Closing issue. /savetoolbar has been removed, as it is now supported in game. We haven't heard of any further issues with this bug.