search

midspace / Space-Engineers-Admin-script-mod

Modding script for Space Engineers with dozens of Admin commands for creating game scenarios or supporting servers.
43 stars 13 forks source link

Enhancing with Faction chat #145

Open midspace opened 8 years ago

midspace commented 8 years ago

The current intent and purpose of private messaging is covered by the wiki here: https://github.com/midspace/Space-Engineers-Admin-script-mod/wiki/Private-messaging

Reading it currently, you can understand that there is no functionality to support chatting with your faction only. I haven't really had a close look at the code myself as @Spcemarine wrote most of this part of the logic.

Chat functionality is kind of weird in Space Engineers, as there is a communication panel for sending messages to individuals, factions, and globally. It is of course supported by the antenna and laser communication systems in game. So why KeenSWH have not implemented a method for turning off the global chat box, I do not know.

procyon1980 aka @Intueor has been working on code, which I have not had time to look at yet. I'm hopeful this can be integrated. Currently there is this pull request. https://github.com/midspace/Space-Engineers-Admin-script-mod/pull/144

I'm posting their details of the pull request here, so everyone is on the same page. :grin:

procyon1980 wrote:

There are some drawbacks in the proposed files. It is related to the fact that I have tried to make changes in the original source as few as possible: 1) in the file "MessagePrivateMessage.cs" - removed the original message "whispers"; 2) in the file "CommandPrivateMessage.cs" - there is no help for new comands; 3) in the file "CommandPrivateMessage.cs" - "void SendFactionMessage (IMyPlayer receiver, string message)" and "void SendPrivateMessage(IMyPlayer receiver, string message)" are nearly same and it is easy to make combined variant.

And yes, I have not implement any commands for swithcing on\off global chat, but it strongly needed of course. Instead of this, I have rip off some data :) to the http://steamcommunity.com/sharedfiles/filedetails/?id=594876108 because I have time deficit too.