search

midudev / kings-league-project

API y website de la Kings League Infojobs por temas didácticos
https://kingsleague.dev
MIT License
1.52k stars 227 forks source link

fix header background color #257

Closed felixicaza closed 1 year ago

felixicaza commented 1 year ago

This is related with the issue #248.

I'm proposing a new color for the background header, because it does not have good contrast with the team logos.

Current:

Screenshot_2023-01-08_08-48-39

(Edit: update proposals)

Option 1:

Screenshot_2023-01-08_12-10-59

Option 2 (add black border - pending to commit):

Screenshot_2023-01-08_12-14-30

Option 3 (add shadow - pending to commit):

Screenshot_2023-01-08_12-09-50

1fbr commented 1 year ago

I assume the current one is like that to try to match the design of the logo. Can you add a black outline to your proposal?
I think it could combine the two proposals well.

felixicaza commented 1 year ago

I assume the current one is like that to try to match the design of the logo. Can you add a black outline to your proposal? I think it could combine the two proposals well.

Yes, I also like the style to match the logo design, but it doesn't have good contrast with some logos, so I just reversed the colors.

I don't understand about the black outline, can you provide a reference? So I could give it a try.

1fbr commented 1 year ago

Yes, I also like the style to match the logo design, but it doesn't have good contrast with some logos, so I just reversed the colors. I don't understand about the black outline, can you provide a reference? So I could give it a try.

Yes, I like the way you have inverted the colour. My suggestion is to add an extra black outline. So it would be, black - yellow - black - yellow like the logo. The original has this black outline, notice when this line connects with the logo, it looks better in my opinion.

felixicaza commented 1 year ago

Yes, I also like the style to match the logo design, but it doesn't have good contrast with some logos, so I just reversed the colors. I don't understand about the black outline, can you provide a reference? So I could give it a try.

Yes, I like the way you have inverted the colour. My suggestion is to add an extra black outline. So it would be, black - yellow - black - yellow like the logo. The original has this black outline, notice when this line connects with the logo, it looks better in my opinion.

You mean something like this?

Screenshot_2023-01-08_11-43-51

1fbr commented 1 year ago

@Felix-Icaza Yes, what do you think?

felixicaza commented 1 year ago

@Felix-Icaza Yes, what do you think?

It makes a lot of sense your suggestion. I just added a new suggestion where I add a shadow and attached fullscreen screenshots for better viewing, you can take a look at it.

I will draft the PR while we can decide.

1fbr commented 1 year ago

It makes a lot of sense your suggestion. I just added a new suggestion where I add a shadow and attached fullscreen screenshots for better viewing, you can take a look at it.

I will draft the PR while we can decide.

Both seem good to me, actually. It would be good to have more opinions.

felixicaza commented 1 year ago

Hi @midudev, what do you think?