midudev / kings-league-project

API y website de la Kings League Infojobs por temas didácticos
https://kingsleague.dev
MIT License
1.52k stars 227 forks source link

fix error reading empty matches & team cards bug #267

Closed felipetodev closed 1 year ago

felipetodev commented 1 year ago

Fixes: https://github.com/midudev/kings-league-project/issues/277

Screenshot:

1. NextMatchesTable

Captura de pantalla 2023-01-08 a la(s) 16 19 40

2. TeamsSelectorCards bug

image image
PChaparro commented 1 year ago

Hi @felipetodev, What do you think about add something like the following code instead of the optional chaining to avoid render an empty header:

{
    firstDayWithPendingMatches && (
        <div class='relative overflow-x-auto shadow-md sm:rounded-lg'>
                ...
        </div>
    )
}
felipetodev commented 1 year ago

Hi @felipetodev, What do you think about add something like the following code instead of the optional chaining to avoid render an empty header:

{
  firstDayWithPendingMatches && (
      <div class='relative overflow-x-auto shadow-md sm:rounded-lg'>
                ...
      </div>
  )
}

you right! thanks 4 the advice @PChaparro ✌️

PChaparro commented 1 year ago

@felipetodev Can you confirm if closing the non closed <div> tag fixes the #277 issue?

felipetodev commented 1 year ago

@felipetodev Can you confirm if closing the non closed <div> tag fixes the #277 issue?

Yes, closing that div that section works correctly

PChaparro commented 1 year ago

Yes, closing that div that section works correctly

Nice! Can you add the issue number on the pull request description? That will make the issue to close automatically when this pull request goes merged.

You can add it like this:

Fixes: # 277

(Remove the space between the # and the number).

felipetodev commented 1 year ago

Yes, closing that div that section works correctly

Nice! Can you add the issue number on the pull request description? That will make the issue to close automatically when this pull request goes merged.

You can add it like this:

Fixes: # 277

(Remove the space between the # and the number).

Ready. Thank you! @PChaparro 🫰