search

midusi / handshape_datasets

A single library to (down)load all existing sign language handshape datasets.
GNU Affero General Public License v3.0
13 stars 2 forks source link

The 'folderpath' should be received by the class on creation #15

Closed facundoq closed 4 years ago

facundoq commented 5 years ago

I know I wanted the DatasetLoader class to be stateless, but passing around the path is a chore and anyhow we create a new instance of a Loader every time we call handshape_datasets.load so there is not need to keep it stateless.

This would make it easier also to generate subpaths once in the constructor, and not repeat code in each functions (download, preprocess,load)