Closed facundoq closed 4 years ago
related https://github.com/midusi/handshape_datasets/issues/17
I think download methods should raise a standard DownloadError exception and preprocessing methods should raise a PreprocessingError exception to standardize error handling
The template method in
DatasetLoader.get
+ should check and set the flags for downloading and preprocessing.The
download_dataset
andpreprocess
methods should not contain any flag setting. Maybe they could return a boolean or even better raise an exception to check if they failed?