Flag setting/checking should be done outside download/preprocess functions

midusi / handshape_datasets

A single library to (down)load all existing sign language handshape datasets.

GNU Affero General Public License v3.0

13 stars 2 forks source link

Flag setting/checking should be done outside download/preprocess functions #16

Closed facundoq closed 4 years ago

facundoq commented 5 years ago

The template method in DatasetLoader.get+ should check and set the flags for downloading and preprocessing.

The download_dataset and preprocess methods should not contain any flag setting. Maybe they could return a boolean or even better raise an exception to check if they failed?

facundoq commented 5 years ago

I think download methods should raise a standard DownloadError exception and preprocessing methods should raise a PreprocessingError exception to standardize error handling