midusi / handshape_datasets

A single library to (down)load all existing sign language handshape datasets.
GNU Affero General Public License v3.0
13 stars 2 forks source link

Simplify downloading when subclassing DatasetLoader #17

Closed facundoq closed 4 years ago

facundoq commented 5 years ago

I think the download of files could be simplified when subclassing DatasetLoader by structuring a bit more. For example, you could specify a list of DownloadFile objects with url and filepaths, and then in the download just foreach them and call download on them.

Check the gist https://gist.github.com/facundoq/6f88d71d5e18fe1307f0735bb7d41bf8 for the idea. @brianRey2017 plz check if this could work, you've got more experience with the subclassing to see if it is viable