midusi / handshape_datasets

A single library to (down)load all existing sign language handshape datasets.
GNU Affero General Public License v3.0
13 stars 2 forks source link

Create comments for DatasetLoader #4

Closed brianRey2017 closed 5 years ago

brianRey2017 commented 5 years ago
brianRey2017 commented 5 years ago

@facundoq Esta función tiene un parametro value que no termino de entender cual es su uso

def _set_status_flag(self, path, status, value=True):
        """
        Flags are used as a way to control that a stage ended successfully.
        This method creates a file used for that control process.

        Args:
            path(str): The path where the status file will be created
            status(str): The name of the status file
        """
        status_path = os.path.join(path, status)
        if not os.path.exists(status_path):
            open(status_path, 'a').close()
        else:
            raise ValueError(f"Status {status} already set on {path}")
brianRey2017 commented 5 years ago

All the work is done. @facundoq Check the comments. If you approve it, close the issue :smile:

facundoq commented 5 years ago

@brianRey2017 El value estaba originalmente para que si es True se cree el archivo, y si es False se borre. Después me di cuenta que no era necesario porque no tiene sentido poner en False eso.

Quedó joya!