midzer / tobii

An accessible, open-source lightbox with no dependencies
https://midzer.github.io/tobii/demo/
MIT License
196 stars 20 forks source link

No/wrong recalculating of counter after removal of item #100

Closed domaxistd closed 1 year ago

domaxistd commented 2 years ago

Hello, it seems that the counter does not recalculate after an item is removed.

  1. i add several images to the lightbox -> counter is right
  2. i remove an image -> counter is wrong (shows too much items, numbers are mixed)

Is there any workaround or quick fix?

Thanks in advance! Maxi

midzer commented 2 years ago

Hi @domaxistd

first of all, thanks for opening this issue.

I have to investigate, never used the tobii counter feature myself. Looks like it's related to https://github.com/midzer/tobii/issues/93.

domaxistd commented 2 years ago

Thanks for the fast respond! @midzer

Another problem that occurs is that when i remove and add multiple items, the lightbox shows too much items. For example:

I have already tried to reset the lightbox after i remove an item but that doesn't seem to work.

Maybe this helps you find the problem.

domaxistd commented 1 year ago

Any progress or findings yet?

midzer commented 1 year ago

@domaxistd Sorry, I was rather busy the last months. Now, over the holidays I can investigate.

midzer commented 1 year ago

Should be fixed by https://github.com/midzer/tobii/commit/b84f9be159d4371ca728c7f048e8c480db0409c2

Can you give it a try, @domaxistd?

domaxistd commented 1 year ago

@midzer problem solved, thanks!