midzer / tobii

An accessible, open-source lightbox with no dependencies
https://midzer.github.io/tobii/demo/
MIT License
196 stars 20 forks source link

missing close button for inline elements in some cases #104

Closed viliusle closed 1 year ago

viliusle commented 1 year ago

If users will open modal dialog on Inline HTML elements, close button may not be visible if matching all conditions below:

  1. at least if device is mobile android (chrome). Sadly chrome mobile emulator does not reproduce this bug !
  2. inline dialog has lots of content (scrollbar activates).

To reproducer it:

  1. edit https://midzer.github.io/tobii/demo/ and add lots of content for "Inline HTML" section to force scrollbar to appear.
  2. open it on mobile (android, Chrome) and open "Inline HTML" modal window
  3. most of close button will not be visible .

What happens?

There is CSS rule .tobii__slide [data-type] with value of: max-height: var(--slide-max-height); or max-height: calc(100vh - 2.77778em). Because this element is centered, layout shifts to top and hides most of close button. But I can not understand why desktop chrome and mobile chrome renders this situation in different ways.

Possible solution

Replace above line to: max-width: 100%.

p.s. more testing must be made before this can be updated.

viliusle commented 1 year ago

Related:

midzer commented 1 year ago

Hi @viliusle. Thanks for filing!

Let's try your proposed solution in develop branch.