midzer / tobii

An accessible, open-source lightbox with no dependencies
https://midzer.github.io/tobii/demo/
MIT License
196 stars 20 forks source link

Multiple Videos on a Single Page #109

Open TMHDesign opened 1 year ago

TMHDesign commented 1 year ago

The link elements below all open a modal, but every one opened only has the data-id for the first element. I have a page with 100 video thumbnails, and want to open each one upon a click.

<a href="javascript:void" data-type="youtube" data-id="98DXe3uKwfc" class="lightbox">ABS Braking System</a> <a href="javascript:void" data-type="youtube" data-id="bRcDvCj_JPs" class="lightbox">Partial Clutch Depression</a> <a href="javascript:void" data-type="youtube" data-id="devo3kdSPQY" class="lightbox">How Clutches Work</a> <a href="javascript:void" data-type="youtube" data-id="ewcWN-rHQ6Q" class="lightbox">Electric vs. Petrol</a> <a href="javascript:void" data-type="youtube" data-id="3SAxXUIre28" class="lightbox">How Electric Autos Work</a> <a href="javascript:void" data-type="youtube" data-id="ARd-Om2VyiE" class="lightbox">Planetary Gear Set</a> <a href="javascript:void" data-type="youtube" data-id="auQgOtveQi0" class="lightbox">Automatic vs. Manual Transmission</a> <a href="javascript:void" data-type="youtube" data-id="lFAtc-zOKZs" class="lightbox">Dual Clutch Transmission</a>

midzer commented 1 year ago

Hi @TMHDesign

Do I understand the issue correctly, that you want to open multiple videos with a single click?

viliusle commented 1 year ago

Strange bug, but if you add correct href attribute like href="https://www.youtube.com/watch?v=RK1K2bCg4J8" for each video, it will work fine.

p.s. it is recommended to use normal href if user wants to open video in new tab for example. p.s.s. readme.MD must be edited or this should be fixed.

midzer commented 1 year ago

Can you have a closer look, @viliusle?