midzer / tobii

An accessible, open-source lightbox with no dependencies

https://midzer.github.io/tobii/demo/

MIT License

196 stars 20 forks source link

updates #73

Closed viliusle closed 3 years ago

viliusle commented 3 years ago

63 - better demo

72 fixed building on Windows, also "npm run dev-modern"

68 - Documentation improvements (data attributes) - already on your production branch

iframe improvements

viliusle commented 3 years ago

OK, but some lint rules are wrong. For example saying, that commands font-weight: bold; or background: #ffffff; or color: #55aa22; are incorrect, is silly... This makes code writing much slower.

Also JS without ";" and tab size with only 2 spaces is very strange for me, but I will try to adapt to these. Basically code auto-format on save works well.

Can I submit issue about some lint rules?

midzer commented 3 years ago

If you want to improve lint rules, feel free to open an issue, @viliusle