Closed bifbof closed 12 months ago
Patch coverage: 97.67%
and project coverage change: -0.07%
:warning:
Comparison is base (
93ad546
) 93.35% compared to head (1c2697d
) 93.29%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Will reopen this PR after #538 and #539 went through, like this it makes no sense.
(This PR should not be reviewed before #537, as the changes are also included here)
Still trying to fix the circular imports for #535. The problem here is with
@_copy_docstrings
. For this function we import code from all I/O modules. This creates the following circular import:io/file.py
importsPositionfixes
to return them as value, butPositionfixes
already imports code fromio/file.py
to copy the docstring in@_copy_docstring
. To fix this, this PR includes the following changes:_copy_docstring
with the new decoratordoc
, it is a really neat function that I copied from pandas It allows formatting docstrings nicely, like class method and a separate function definition to format the same docstring to their liking._shared_doc
to allow docstrings to be shared beyond pairs. Useful e.g. forpostgis_write
functions that already use the same docstring.I have only included the changes for
Positionfixes
so as not to make this PR too large. The other classes will follow in another PR.