miegl / PiFmAdv

Advanced Raspberry Pi FM transmitter with RDS encoding
GNU General Public License v3.0
484 stars 82 forks source link

Group 4A missing TP and PTY #110

Open KubaPro010 opened 3 months ago

KubaPro010 commented 3 months ago

When checking out the code of my rpitx2 rds generator (and implementing my python rds encoder, rdPy), i've stumbled opun a bug in the 4A group generation, the code sets blocks[1] which should contain the TP and PTY and something else which is not important now, (https://github.com/miegl/PiFmAdv/blob/master/src/rds.c#L88) we set it to what the 4A group needs, however we are missing the PTY and TP

EDIT: also something with 4A but not the blocks, but is the mjd generation correct? the mon+2 part seems incorrect as the rds docs say it should be mon+1 instead

KubaPro010 commented 3 months ago

I've also now concluded why it doesnt have tp or pty, because it was untouched since pifmrds from 6+ years ago, nothing was changed since by anyone, pifmrds didnt have tp or pty or af, it was extremely basic for the group gen