search

miegl / PiFmAdv

Advanced Raspberry Pi FM transmitter with RDS encoding
GNU General Public License v3.0
487 stars 82 forks source link

termination issue with no audio #28

Closed morrolinux closed 6 years ago

morrolinux commented 6 years ago

What I'm doing: sox someinput | pi_fm_adv ... --wait 0 I don't really understand why, but when sox playback finishes, the shell hangs indefinitely, there is no CTRL+C / CTRL+Z response, and killing -9 pi_fm_adv process seem to have no effect! the pid won't die, although the shell is working...

PS: I'm on a Pi3 (the only device I seem to have managed to get working with)

miegl commented 6 years ago

I think this is related to the i/o issue. So once that will be fixed (idk how and when) this should work.

morrolinux commented 6 years ago

Damn! you're probably right.

miegl commented 6 years ago

With the current state of the raspberry pi firmware the only thing I can do now is trial and error. Don't know how long that will take though and theres a big possibility the firmware will break it anyway.

Niall7459 commented 6 years ago

I find that the previous way of modulating the wave before PLLC is more reliable. Although it would be great for the PLLC to work. And even then I think the DMA engine should be changed as that solved my problem for the GUI freezing

morrolinux commented 6 years ago

@Niall7459 could you be a bit more specific about the "DMA engine change" stuff?

miegl commented 6 years ago

@Niall7459 yes it is. But it's also not very usable quality wise. I've actually changed the DMA channel from 5 to 14 so I guess it can't be a problem now https://github.com/Miegl/PiFmAdv/commit/91fbb0b5100238c068b1db9f305b94593651b254

miegl commented 6 years ago

So I just pushed https://github.com/Miegl/PiFmAdv/commit/c9a50abfe046d2fafab73623610c8785fc8ed002

Let me know if it works this time @Niall7459 @morrolinux (test on multiple pis with multiple systems please :)

miegl commented 6 years ago

The main goal is to get it working on latest firmware, so if it doesn't work on older one it's not a problem

morrolinux commented 6 years ago

Good News! Termination works correctly on both my Pi1 and the Pi3 As for the stability, I'll test further tomorrow UPDATE: Seems to be working properly even on Pi0. Tested for half an hour, never crashed.

Niall7459 commented 6 years ago

@morrolinux @Miegl I can do some tests for like 24 hours etc in a couple of days. and il get back to you with the results.