search

miek / inspectrum

Radio signal analyser
GNU General Public License v3.0
2.09k stars 270 forks source link

Use viridis colormap #204

Open tammojan opened 2 years ago

tammojan commented 2 years ago

This uses the viridis colormap, and includes support for many other colormaps. I'm not totally sure if just including the header of https://github.com/yuki-koyama/tinycolormap is allowed license-wise, perhaps @yuki-koyama can comment. I think setting up cmake to use submodules just for one file be a bit of an overkill.

yuki-koyama commented 2 years ago

Hi, tinycolormap is MIT-licensed. So, it is allowed to directly copy and include (and even modify if necessary) the header file into any other projects, as long as the original copyright and permission notices are included somewhere.

tammojan commented 2 years ago

Thanks @yuki-koyama! So only including the header file (and not deleting the copyright lines which are part of the header) is ok?

yuki-koyama commented 2 years ago

In my understanding, yes

miek commented 2 years ago

Thanks for the PR. I like the idea of this but I don't want to just swap out the current colormap with a new one. I would be interested in a change that allowed different selectable colormaps though.