search

miekg / caddy-prometheus

Prometheus metrics middleware for caddy
Apache License 2.0
65 stars 26 forks source link

Would it be possible to listen on the same port as Caddy itself? #30

Closed hairyhenderson closed 6 years ago

hairyhenderson commented 7 years ago

Obviously if we wanted Caddy to serve up another /metrics endpoint there'd be a conflict, but it'd be really useful if we only needed to expose a single port from Caddy for certain use-cases.

miekg commented 7 years ago

Currently not possible because this middleware adds its own handler. caddy-git listens for incoming webhooks from github on the default caddy port I think. So you might get some inspiration from there if you want to add this

hairyhenderson commented 7 years ago

Thanks @miekg for the pointer - I'll have a look at that!

hairyhenderson commented 6 years ago

@miekg this totally fell through the cracks - until today! 😉 I've proposed #35 to solve this.

miekg commented 6 years ago

Saw it. Thanks! Will take a look this evening.

On 20 Jan 2018 19:55, "Dave Henderson" notifications@github.com wrote:

@miekg https://github.com/miekg this totally fell through the cracks - until today! 😉 I've proposed #35 https://github.com/miekg/caddy-prometheus/pull/35 to solve this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/miekg/caddy-prometheus/issues/30#issuecomment-359193726, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVkWzIS9DVp2--H7qIHH-azivZBCHmoks5tMja8gaJpZM4PJOAZ .