search

miekg / caddy-prometheus

Prometheus metrics middleware for caddy
Apache License 2.0
65 stars 26 forks source link

Change Family tag to understandable values #46

Closed genofire closed 5 years ago

genofire commented 5 years ago

It should not be "1" and "2". For IPv4 it should be "4" and IPv6 should be "6". On this way, everybody understand those values.

Like everywhere, even the IPvX-header use the right value with his only four bits.

miekg commented 5 years ago

[ Quoting notifications@github.com in "[miekg/caddy-prometheus] Change Fam..." ]

It should not be "1" and "2". For IPv4 it should be "4" and IPv6 should be "6". On this way, everybody understand those values.

Like everywhere, even the IPvX-header use the right value with his only four bits.

the offical list is here: https://www.iana.org/assignments/address-family-numbers/address-family-numbers.xhtml

/Miek

-- Miek Gieben