search

miekg / caddy-prometheus

Prometheus metrics middleware for caddy
Apache License 2.0
65 stars 26 forks source link

Refactor extra labels handling to structs #49

Closed Baldinof closed 5 years ago

Baldinof commented 5 years ago

The current code assumes that multiple iterations over a map will be in the same order, but it is not guaranteed.

From the Golang spec:

The iteration order over maps is not specified and is not guaranteed to be the same from one iteration to the next

Baldinof commented 5 years ago

Ping @miekg

Baldinof commented 5 years ago

Nice! Thank you :)