search

miekg / caddy-prometheus

Prometheus metrics middleware for caddy
Apache License 2.0
65 stars 26 forks source link

caddy's importpath changed #55

Closed miekg closed 5 years ago

miekg commented 5 years ago

The import path changed, update to the new one.

ghost commented 5 years ago

@miekg Can you publish a new release so that people can build Caddy from source with this plugin without having to specify the hash of this commit in their go.mod file?

miekg commented 5 years ago

[ Quoting notifications@github.com in "Re: [miekg/caddy-prometheus] caddy'..." ]

@miekg Can you publish a new release so that people can build Caddy from source with this plugin without having to specify the hash of this commit in their go.mod file?

We've never released. "go get" will do this for you automatically

hairyhenderson commented 5 years ago

the go.mod file still references the old caddy path - that might be causing problems... I'll issue a PR soon.

hairyhenderson commented 5 years ago

See #56

ghost commented 5 years ago

@miekg Just tested it and can confirm that you're right. It looks like that step would only have been necessary if you had tagged one of your releases as "latest." As of v1.12.7, Go fetches the latest version by default and only resorts to the latest commit if there is no version tagged as "latest."